A site icon the page names but that is missing is stored anyway #79
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
feed::site_icon takes the icon a site's page names in its tags without checking it exists, so it never falls back to /favicon.ico. antirez.com's feed (http://antirez.com/rss) has no artwork; its home page names /images/favicon.png, which 404s, while https://antirez.com/favicon.ico is a real image/x-icon. The miss is stored once and never looked for again (main.rs, the 'Looked for once' block), so the feed shows no art. Found looking into why antirez's feed has no image.
Fixed in
95a8633: site_icon now checks that the icon a page names answers with an image before using it, and falls back to /favicon.ico otherwise. Deployed. A feed that already has the dead URL stored keeps it until its image is cleared, since the lookup happens once.