A feed set to download 0 downloads nothing, though the dialog says 0 means every episode #166

Closed
opened 2026-10-08 19:28:34 -07:00 by rays · 1 comment
Owner

Found 2026-10-09 while redesigning the feed settings dialog. The dialog says "0 means every episode, the whole back catalogue", and 0 does mean that as the server's default. But merge_policy's cap() (src/main.rs) turns only the server-wide 0 into unlimited: a 0 on one feed, or on one person's subscription to it, becomes a budget of 0, hold_back then holds every file, and nothing downloads automatically.

No test covers a per-feed 0. In production rays has no feed at 0 (two archived shows are at 100 and 10000, which may be why); another account's settings could not be checked from here, and a feed someone did set to 0 will start downloading its whole back catalogue once this is fixed, which is what they asked for.

Fix: 0 is unlimited wherever it is set.

Found 2026-10-09 while redesigning the feed settings dialog. The dialog says "0 means every episode, the whole back catalogue", and 0 does mean that as the server's default. But merge_policy's cap() (src/main.rs) turns only the server-wide 0 into unlimited: a 0 on one feed, or on one person's subscription to it, becomes a budget of 0, hold_back then holds every file, and nothing downloads automatically. No test covers a per-feed 0. In production rays has no feed at 0 (two archived shows are at 100 and 10000, which may be why); another account's settings could not be checked from here, and a feed someone did set to 0 will start downloading its whole back catalogue once this is fixed, which is what they asked for. Fix: 0 is unlimited wherever it is set.
rays added the bug label 2026-10-08 19:28:34 -07:00
Author
Owner

Fixed in 19f77a2: merge_policy's cap() takes 0 as unlimited wherever it is set, the server's default, a feed's or one person's, with a test of each. Deployed as 0.10.3-dev. A feed anyone had set to 0 now downloads its whole back catalogue, as the dialog said it would; none of rays's feeds is at 0.

Fixed in 19f77a2: merge_policy's cap() takes 0 as unlimited wherever it is set, the server's default, a feed's or one person's, with a test of each. Deployed as 0.10.3-dev. A feed anyone had set to 0 now downloads its whole back catalogue, as the dialog said it would; none of rays's feeds is at 0.
rays closed this issue 2026-10-08 19:45:04 -07:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rays/ipx#166