A Signal's own icon, from all of Font Awesome Free, searchable (#261)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tests/page-unit.js

@@ -154,3 +154,31 @@ test('a Signal is a place of its own, found by its id', () => {
   assert.match(run(`listUrl(':signal:7')`), /^\/api\/signals\/7\/entries\?/);
   run(`S.signals = []`);
 });
+
+test('the icon picker finds icons by the start of their words, the one named it first', () => {
+  const all = JSON.stringify([
+    ['solid/caret-down', 'Caret Down', 'arrow'], ['solid/scarf', 'Scarf', 'clothing'], ['solid/taxi', 'Taxi', 'cab car'],
+    ['solid/car-side', 'Car Side', 'auto vehicle'], ['solid/car', 'Car', 'auto vehicle'], ['solid/robot', 'Robot', 'ai bot machine'],
+    ['brands/apple', 'Apple', 'fruit ios mac'],
+  ]);
+  const ids = q => JSON.parse(run(`JSON.stringify(iconMatches(${all}, ${JSON.stringify(q)}, 10).map(i => i[0]))`));
+  // Named car, then car as a word of the name, then as a search term, then caret; never scarf.
+  assert.deepEqual(ids('car'), ['solid/car', 'solid/car-side', 'solid/taxi', 'solid/caret-down']);
+  assert.deepEqual(ids('ai'), ['solid/robot'], 'search terms count');
+  assert.deepEqual(ids('mac fruit'), ['brands/apple'], 'every word');
+  assert.equal(run(`iconMatches(${all}, '', 2).length`), 2, 'nothing typed is the first few');
+});
+
+test('editing a Signal sends only what changed, so a new icon asks Jev nothing again', () => {
+  const sg = `{id: 1, name: 'F1', keywords: ['f1'], description: null, icon: null, unread: 0}`;
+  assert.deepEqual(JSON.parse(run(`JSON.stringify(signalChanges(${sg}, {name: 'F1', keywords: ['f1'], description: null, icon: 'solid/car'}))`)),
+    { icon: 'solid/car' });
+  assert.deepEqual(JSON.parse(run(`JSON.stringify(signalChanges(${sg}, {name: 'F1', keywords: ['f1', 'gp'], description: null, icon: null}))`)),
+    { keywords: ['f1', 'gp'] });
+});
+
+test('a Signal draws its icon only when it is a style and a plain name', () => {
+  assert.match(run(`signalTile({name: 'F1', icon: 'solid/flag-checkered'})`), /url\('\/icons\/solid\/flag-checkered\.svg'\)/);
+  assert.doesNotMatch(run(`signalTile({name: 'F1', icon: "solid/x');background:url(evil"})`), /evil/);
+  assert.doesNotMatch(run(`signalTile({name: 'F1', icon: null})`), /ficon/);
+});

tests/ui/app.spec.js

@@ -2084,9 +2084,15 @@ test('a Signal holds the items Jev says fit its keywords, read where they are re
   await page.locator('#sgname').fill('F1');
   await page.locator('#sgkwin').fill('monaco');
   await page.keyboard.press('Enter');
+  // An icon of its own, found by searching Font Awesome Free (#261).
+  await page.locator('#sgicon').click();
+  await page.locator('#sgiconq').fill('flag checkered');
+  await page.locator('[data-ic="solid/flag-checkered"]').click();
   await page.locator('#sgsave').click();
   const row = page.locator('#feedlist .feed.child', { hasText: 'F1' });
   await expect(row).toHaveClass(/sel/);
+  await expect(row.locator('.ficon')).toHaveAttribute('style', /\/icons\/solid\/flag-checkered\.svg/);
+  expect((await page.request.get('/icons/solid/flag-checkered.svg')).status()).toBe(200);
 
   const signals = async () => (await (await page.request.get('/api/signals')).json());
   const sg = (await signals()).find(s => s.name === 'F1');