rays/pylibmc
Archived
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve error checking for increment and decrement.

Browse Source
This commit is contained in:
lericson 2009-09-21 16:42:37 +02:00
parent 91d9e035e9
commit aa74c13d84
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
_pylibmcmodule.c
View File

@ -331,17 +331,26 @@ static PyObject *_PylibMC_IncDec(PylibMC_Client *self, uint8_t dir,
Py_ssize_t key_sz; Py_ssize_t key_sz;
unsigned int delta; unsigned int delta;
uint64_t result; uint64_t result;
memcached_return rc;
memcached_return (*incdec)(memcached_st *, const char *, size_t,
unsigned int, uint64_t *);
retval = NULL; retval = NULL;
delta = 1; delta = 1;
if (PyArg_ParseTuple(args, "s#|I", &key, &key_sz, &delta) if (!PyArg_ParseTuple(args, "s#|I", &key, &key_sz, &delta)) {
&& _PylibMC_CheckKeyStringAndSize(key, key_sz)) { return retval;
memcached_return (*incdec)(memcached_st *, const char *, size_t, } else if (!_PylibMC_CheckKeyStringAndSize(key, key_sz)) {
unsigned int, uint64_t *); return retval;
incdec = (dir == PYLIBMC_INC) ? memcached_increment }
: memcached_decrement;
incdec(self->mc, key, key_sz, delta, &result); incdec = (dir == PYLIBMC_INC) ? memcached_increment : memcached_decrement;
rc = incdec(self->mc, key, key_sz, delta, &result);
if (rc == MEMCACHED_SUCCESS) {
retval = PyLong_FromUnsignedLong((unsigned long)result); retval = PyLong_FromUnsignedLong((unsigned long)result);
} else {
char *fname = (dir == PYLIBMC_INC) ? "memcached_increment"
: "memcached_decrement";
PylibMC_ErrFromMemcached(self, fname, rc);
} }
return retval; return retval;