rays/ipx
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove subscribing the first admin to the catalogue #86

New Issue
Closed
opened 2026-09-29 06:06:59 -07:00 by rays · 1 comment
rays commented 2026-09-29 06:06:59 -07:00
Owner
Copy Link

Db::adopt_catalogue (src/db.rs:1146), its call at startup (src/main.rs:404) and its test, about 40 lines. It was the one-off move from before accounts, when the catalogue was everyone's; a fresh install has an empty catalogue, so it does nothing there, and production has run it. Found in a repo-wide audit for code that can go.

Db::adopt_catalogue (src/db.rs:1146), its call at startup (src/main.rs:404) and its test, about 40 lines. It was the one-off move from before accounts, when the catalogue was everyone's; a fresh install has an empty catalogue, so it does nothing there, and production has run it. Found in a repo-wide audit for code that can go.
rays added the enhancement label 2026-09-29 06:06:59 -07:00
rays commented 2026-09-29 06:12:13 -07:00
Author
Owner
Copy Link

Not a one-off, so not removing it. It is how a fresh install's first account gets the feeds config.toml listed, and the browser suite relies on it for its admin's sidebar (the test's comment says an earlier removal broke exactly that). The audit assumed it only ever ran on production; that was wrong.

Not a one-off, so not removing it. It is how a fresh install's first account gets the feeds config.toml listed, and the browser suite relies on it for its admin's sidebar (the test's comment says an earlier removal broke exactly that). The audit assumed it only ever ran on production; that was wrong.
rays closed this issue 2026-09-29 06:12:14 -07:00
rays added wontfix and removed enhancement labels 2026-09-29 06:12:15 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label wontfix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rays
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rays/ipx#86
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?