Remove the move of feeds and settings from config.toml into the database #84

Closed
opened 2026-09-29 06:06:58 -07:00 by rays · 1 comment
Owner

The import branch of assemble_config (src/main.rs:805), Db::import_config (src/db.rs:1035), Config::file_holds_stored (src/config.rs:338), the warning about config.toml still listing feeds, and their two tests, about 110 lines. It ran once, on production, on 2026-09-18 (#18), and runs on nothing else. Found in a repo-wide audit for code that can go.

The import branch of assemble_config (src/main.rs:805), Db::import_config (src/db.rs:1035), Config::file_holds_stored (src/config.rs:338), the warning about config.toml still listing feeds, and their two tests, about 110 lines. It ran once, on production, on 2026-09-18 (#18), and runs on nothing else. Found in a repo-wide audit for code that can go.
rays added the enhancement label 2026-09-29 06:06:58 -07:00
Author
Owner

Not a one-off, so not removing it. The browser suite writes its fixture feeds into config.toml (tests/ui/global-setup.js) and depends on this import to get them into the database, and it is how a fresh install starts from a config.toml that lists feeds. The audit assumed it only ever ran on production; that was wrong.

Not a one-off, so not removing it. The browser suite writes its fixture feeds into config.toml (tests/ui/global-setup.js) and depends on this import to get them into the database, and it is how a fresh install starts from a config.toml that lists feeds. The audit assumed it only ever ran on production; that was wrong.
rays closed this issue 2026-09-29 06:12:13 -07:00
rays added wontfix and removed enhancement labels 2026-09-29 06:12:14 -07:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rays/ipx#84