Pinned and read look different in each place they are shown #74
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found in a sweep of every theme and mode. Pinned is the accent colour in the feed list, the text colour on an item's row, and not coloured at all on the toolbar, the item's own buttons and the feed page, which only swap outline for solid. The read button shows what clicking does (an envelope on a read item: mark unread) while the pin beside it shows what is (solid when pinned), so the two buttons side by side read in opposite ways. The toolbar and the item's buttons also set no aria-pressed, so screen readers get no state.
Fixed in
4ed2d59anda5de4ae: toggles show their state, not the action. The read button is a tick when read and the envelope when not, as the pin is solid when pinned; the toolbar and the item's buttons set aria-pressed. Theme colours unchanged (a first attempt coloured pressed toggles with the accent; reverted ina5de4ae). Deployed.