rays/ipx
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases 20 Wiki Activity

ipx reap --dry-run says it deleted the files it kept #461

New Issue
Closed
opened 2026-11-13 19:55:45 -08:00 by rays · 1 comment
rays commented 2026-11-13 19:55:45 -08:00
Owner
Copy Link

ipx reap --dry-run ("Show what would go, delete nothing") prints deleted <path> (N MB) for each file and deleted N old file(s) at the end, word for word what a real reap prints, though nothing is deleted. Someone checking what a quota would remove reads it as having removed it. The Reaped and ReapDone events carry no dry-run flag (crates/ipx/src/ipc.rs), so the text cannot differ. Found writing a browser test for retention.

`ipx reap --dry-run` ("Show what would go, delete nothing") prints `deleted <path> (N MB)` for each file and `deleted N old file(s)` at the end, word for word what a real reap prints, though nothing is deleted. Someone checking what a quota would remove reads it as having removed it. The Reaped and ReapDone events carry no dry-run flag (crates/ipx/src/ipc.rs), so the text cannot differ. Found writing a browser test for retention.
rays added the bug label 2026-11-13 19:55:45 -08:00
rays commented 2026-11-13 20:01:43 -08:00
Author
Owner
Copy Link

Fixed in f9f50fc, deployed to ipx 2026-11-14 04:01 UTC: Reaped and ReapDone carry dry_run, and a dry run says "would delete" of each file and of the total (production now: would delete 0 old file(s), 0.0 MB). Tested by the browser suite's new retention test, which reaps dry over a tiny quota and checks the files stay.

Fixed in f9f50fc, deployed to ipx 2026-11-14 04:01 UTC: Reaped and ReapDone carry dry_run, and a dry run says "would delete" of each file and of the total (production now: `would delete 0 old file(s), 0.0 MB`). Tested by the browser suite's new retention test, which reaps dry over a tiny quota and checks the files stay.
rays closed this issue 2026-11-13 20:01:44 -08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rays
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rays/ipx#461
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?