Tests: the Directory inside the app #405

New Issue

rays · 2026-11-06T19:51:45-08:00

rays commented

2026-11-06 19:51:45 -08:00

web/src/dialogs.ts's Directory views are largely untested: subscribing from a listing (subscribeListed), a show's page in the app (fillShow: its description with More and Less, its failing note, its recent items), searching the Directory, the back button, and an admin's Refresh and Remove from the directory (lines 263-277). These are how people find and add feeds.

Tests to add:

from a tile, Subscribe adds the feed, says so, and opens it
a show's page shows its description (More expands a long one), its last items, and a failing feed's reason
a search in the Directory narrows the tiles, and says so when nothing matches
as an admin: Refresh asks the directory to check the feed; Remove asks first, then takes it out of the list and blocks it; as anyone else, neither button is there

Seen with the coverage of both suites merged line by line (cargo: sh scripts/coverage.sh, browser: sh scripts/coverage.sh api; reports in target/coverage/cargo, api and page; #390, #394), as of 2026-11-07. A test added here shows in Grafana's Coverage row at the next run.

web/src/dialogs.ts's Directory views are largely untested: subscribing from a listing (`subscribeListed`), a show's page in the app (`fillShow`: its description with More and Less, its failing note, its recent items), searching the Directory, the back button, and an admin's Refresh and Remove from the directory (lines 263-277). These are how people find and add feeds. Tests to add: - from a tile, Subscribe adds the feed, says so, and opens it - a show's page shows its description (More expands a long one), its last items, and a failing feed's reason - a search in the Directory narrows the tiles, and says so when nothing matches - as an admin: Refresh asks the directory to check the feed; Remove asks first, then takes it out of the list and blocks it; as anyone else, neither button is there Seen with the coverage of both suites merged line by line (cargo: `sh scripts/coverage.sh`, browser: `sh scripts/coverage.sh api`; reports in target/coverage/cargo, api and page; #390, #394), as of 2026-11-07. A test added here shows in Grafana's Coverage row at the next run.

rays added the enhancement label 2026-11-06 19:51:45 -08:00

rays commented

2026-11-06 20:45:13 -08:00

Tests added in 5c5dd91: a search with no match ('No feed here has that in its name.', no tiles); a show's page with a long description (More, Less, aria-expanded), its failing reason (#dfail), its latest items, no Refresh or Remove for a non-admin, and Subscribe from the show's page (toast, feed opened). Search, Back, Subscribe from a tile and an admin's Refresh and Remove were already covered by the Directory and #206 tests. Whole browser suite: 108 passed.

Tests added in 5c5dd91: a search with no match ('No feed here has that in its name.', no tiles); a show's page with a long description (More, Less, aria-expanded), its failing reason (#dfail), its latest items, no Refresh or Remove for a non-admin, and Subscribe from the show's page (toast, feed opened). Search, Back, Subscribe from a tile and an admin's Refresh and Remove were already covered by the Directory and #206 tests. Whole browser suite: 108 passed.

rays closed this issue

2026-11-06 20:45:14 -08:00

rays referenced this issue from a commit

2026-11-06 20:45:15 -08:00

Browser tests for the Directory's show page, dialogs, keys and player (#405, #406)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rays/ipx#405