Tests, tooling and two served scripts are still JavaScript #392

Closed
opened 2026-11-06 17:57:45 -08:00 by rays · 1 comment
Owner

The page and the service worker are strict TypeScript, but the browser and Node tests (tests/.js, tests/ui/app.spec.js, its fixture server and setup), the load tests, playwright.config.js, web/build.mjs, the home page generator (site/.mjs), web/boot.js and the directory's crates/directory/src/site.js are plain JavaScript, unchecked. Wanted: all of them TypeScript, type-checked by npm run typecheck. (.agents/skills/security-audit is an installed skill, not ours.)

The page and the service worker are strict TypeScript, but the browser and Node tests (tests/*.js, tests/ui/app.spec.js, its fixture server and setup), the load tests, playwright.config.js, web/build.mjs, the home page generator (site/*.mjs), web/boot.js and the directory's crates/directory/src/site.js are plain JavaScript, unchecked. Wanted: all of them TypeScript, type-checked by npm run typecheck. (.agents/skills/security-audit is an installed skill, not ours.)
rays added the enhancement label 2026-11-06 17:57:45 -08:00
Author
Owner

Done in f8408a3: all 21 files are TypeScript, checked by npm run typecheck in five programs (the page with boot.ts and the directory's site.ts; the worker; Node's; k6's; and the page's declarations, emitted for the browser suite's page.evaluate calls). The site generator's output is byte for byte the same, the page's app.js is identical, all tests pass (browser suite 96 passed, 2 skipped). ipx-web deployed, its image built on Node 24. The directory's and ipx's images were not rebuilt: site.js changed in comments and layout only, and goes out with their next deploy. The load tests were parsed by k6 but not run (they build a release binary outside the capped builder).

Done in f8408a3: all 21 files are TypeScript, checked by `npm run typecheck` in five programs (the page with boot.ts and the directory's site.ts; the worker; Node's; k6's; and the page's declarations, emitted for the browser suite's page.evaluate calls). The site generator's output is byte for byte the same, the page's app.js is identical, all tests pass (browser suite 96 passed, 2 skipped). ipx-web deployed, its image built on Node 24. The directory's and ipx's images were not rebuilt: site.js changed in comments and layout only, and goes out with their next deploy. The load tests were parsed by k6 but not run (they build a release binary outside the capped builder).
rays closed this issue 2026-11-06 18:24:29 -08:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rays/ipx#392