Tests, tooling and two served scripts are still JavaScript #392
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The page and the service worker are strict TypeScript, but the browser and Node tests (tests/.js, tests/ui/app.spec.js, its fixture server and setup), the load tests, playwright.config.js, web/build.mjs, the home page generator (site/.mjs), web/boot.js and the directory's crates/directory/src/site.js are plain JavaScript, unchecked. Wanted: all of them TypeScript, type-checked by npm run typecheck. (.agents/skills/security-audit is an installed skill, not ours.)
Done in
f8408a3: all 21 files are TypeScript, checked bynpm run typecheckin five programs (the page with boot.ts and the directory's site.ts; the worker; Node's; k6's; and the page's declarations, emitted for the browser suite's page.evaluate calls). The site generator's output is byte for byte the same, the page's app.js is identical, all tests pass (browser suite 96 passed, 2 skipped). ipx-web deployed, its image built on Node 24. The directory's and ipx's images were not rebuilt: site.js changed in comments and layout only, and goes out with their next deploy. The load tests were parsed by k6 but not run (they build a release binary outside the capped builder).