A tap's span runs on to requests it did not set off #379
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A tap's root span (#376) lasts until the last answer in its trace, and traceparent() keeps the trace for any request within a minute of the last, so requests no tap set off (a live update's refresh, a timer) stretch it. Trace a895551d20626fb6dc071d336262b772 (2026-10-26 00:07 UTC, phone): the tap's own POST flags and GET /api/signals were answered by 0.9 s, then GET /api/entries at 13.4 s and GET /api/feeds/the-verge/entries at 15.2 s, with no tap or key between, made the tap 15,213 ms. Found with:
query.py spans '{resource.service.name="ipx" && name="tap"}' 12h, then the span start times of that trace. Taps over a few seconds in Tempo are therefore not time anyone waited.Fixed in
08b28f0: a request counts towards the tap only while one of the tap's own is in flight or within two seconds of the tap or its last answer, so a later refresh still joins the trace but no longer stretches the tap. A page-unit test makes a request five seconds after the answer and expects the tap unchanged. Deployed in ipx-web.