The page overflows its stack reporting a tap #378
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On the phone the page shows 'Maximum call stack size exceeded.' endTap (web/src/util.ts, #376) calls report, which calls traceparent(); when the trace is over a minute old (the page hidden after a minute idle, as switching apps on a phone does) traceparent starts a new trace, whose newTrace calls endTap again before rootKind was cleared, and a timing is never throttled, so it recurses until the stack runs out.
Fixed in
070b39e: endTap clears the open tap before reporting it, so the new trace report starts cannot end it again. A page-unit test hides the page two minutes after a request and expects one report; it overflowed the stack before the fix. Deployed in ipx-web.