rays/ipx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 18 Wiki Activity

Other people's download failures and progress show on everyone's page #294

New Issue
Closed
opened 2026-10-19 10:40:16 -07:00 by rays · 1 comment
rays commented 2026-10-19 10:40:16 -07:00
Owner
Copy Link

web/src/events.ts: download_error toasts 'Download failed: ...' for any feed's failed download, and progress writes 'downloading ' into #count for any feed's download. Every page receives every event, and deadair_done already checks mine(ev.feed), but these two do not. So one person's scheduled download failures, and the names of the files being downloaded, appear on another person's page. Found in a repo audit. Fix: return early when !mine(ev.feed).

web/src/events.ts: download_error toasts 'Download failed: ...' for any feed's failed download, and progress writes 'downloading <file>' into #count for any feed's download. Every page receives every event, and deadair_done already checks mine(ev.feed), but these two do not. So one person's scheduled download failures, and the names of the files being downloaded, appear on another person's page. Found in a repo audit. Fix: return early when !mine(ev.feed).
rays added the bug label 2026-10-19 10:40:16 -07:00
rays commented 2026-10-19 11:17:39 -07:00
Author
Owner
Copy Link

Fixed in 995ee05: progress and download_error events for a feed not on this person's list are dropped by the page, as deadair_done already was. Deployed in ipx-web.

Fixed in 995ee05: progress and download_error events for a feed not on this person's list are dropped by the page, as deadair_done already was. Deployed in ipx-web.
rays closed this issue 2026-10-19 11:17:39 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rays
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rays/ipx#294
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?