rays/ipx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 18 Wiki Activity

patch_feed asks for the subscription twice #163

New Issue
Closed
opened 2026-10-08 18:36:27 -07:00 by rays · 1 comment
rays commented 2026-10-08 18:36:27 -07:00
Owner
Copy Link

Found in a code audit on 2026-10-09.

patch_feed (src/web.rs:1560-1565) asks the database for your subscription to see whether there is one, then asks again for it with a fallback for none, which can never run. One if let Some(mut mine) does both.

Found in a code audit on 2026-10-09. `patch_feed` (`src/web.rs:1560-1565`) asks the database for your subscription to see whether there is one, then asks again for it with a fallback for none, which can never run. One `if let Some(mut mine)` does both.
rays added the enhancement label 2026-10-08 18:36:27 -07:00
rays commented 2026-10-08 18:58:49 -07:00
Author
Owner
Copy Link

Done in 2de5f81: one if-let in place of the two lookups. Deployed as 0.10.3-dev on 2026-10-09.

Done in 2de5f81: one if-let in place of the two lookups. Deployed as 0.10.3-dev on 2026-10-09.
rays closed this issue 2026-10-08 18:58:49 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rays
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rays/ipx#163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?