The logs stop repeating what metrics and their own fields say (#363)
iPX logged scan_done after every scan: 921 lines a day, a fifth of the log, nearly all "scan complete, 1 feed(s)" since scans became one or two feeds at a time (#114). ipx_jobs_total, ipx_feed_fetches_total and ipx_last_scan_age_seconds hold all of it. It is routine now, at debug, so the page's log view keeps it. The dashboard's "feeds checked" series and the prod check's check 4 read the metrics instead. ipx-directory wrote each line's span twice, as `span` and in `spans`, and neither added anything: a request's span repeated its method, path and status, refresh.feeds repeated `checked`, a feed span was empty. ipx::http stays: it repeats Caddy's access line and the span, but holds the route pattern and ipx's own time, which the dashboard groups by. The prod check's `status` line was the healthcheck's every 30 s; since #218 it is only `ipx status` run by hand, and the skill says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Changed
|
||||
|
||||
- The log no longer has a line for every scan that finishes, a fifth of its lines; the metrics count scans, and the page's log view still shows them (#363).
|
||||
|
||||
### Fixed
|
||||
|
||||
- A feed you already have, added again by the same address over http rather than https or the other way round, is the one you have, not a second subscription with every item twice. Changing a feed's address to another feed's over the other scheme is refused the same way (#362).
|
||||
|
||||
@@ -307,7 +307,9 @@ fn log_event(e: &Event, wire: bool) {
|
||||
_ => (None, None),
|
||||
};
|
||||
let routine = match e {
|
||||
Event::Progress { .. } | Event::FeedSkip { .. } | Event::FeedStart { .. } => true,
|
||||
// A scan's end: ipx_jobs_total, ipx_feed_fetches_total and ipx_last_scan_age_seconds hold it,
|
||||
// and since scans became one or two feeds at a time it was a fifth of the log (#363).
|
||||
Event::Progress { .. } | Event::FeedSkip { .. } | Event::FeedStart { .. } | Event::ScanDone { .. } => true,
|
||||
Event::FeedDone { new, downloaded, failed, torrents, .. } => {
|
||||
*new == 0 && *downloaded == 0 && *failed == 0 && *torrents == 0
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user